Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treat null and empty string equally for endpoint properties #570

Merged
merged 1 commit into from
Oct 24, 2023
Merged

treat null and empty string equally for endpoint properties #570

merged 1 commit into from
Oct 24, 2023

Conversation

larshagencognite
Copy link
Contributor

This improves the usability of the docker image, as it defaults to empty strings for both properties. With this fix, the docker image will work when only one of the endpoints are set.

@larshagencognite
treat null and empty string equally for endpoint properties
1b8e0c8 
This improves the usability of the docker image, as it defaults
to empty strings for both properties. With this fix, the docker image
will work when only one of the endpoints are set.
@larshagencognite
Copy link
Contributor Author

Alternative to #557

@larshagencognite
Copy link
Contributor Author

Fixes #523, #528 and #556

@gaul gaul merged commit 2281c74 into gaul:master Oct 24, 2023
3 checks passed
@gaul
Copy link
Owner

gaul commented Oct 24, 2023

Thank you for your contribution @larshagencognite!

@gaul gaul mentioned this pull request Oct 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larshagencognite @gaul